Add no-unneeded-ternary lint rule

publish/eslint.config.js

@@ -123,7 +123,7 @@ export default [
             'no-multiple-empty-lines': ['error', { 'max': 1 }],
             // 'no-negated-condition': 'error',
             'no-nested-ternary': 'error',
-            //'no-new': 'error',
+            // 'no-new': 'error',
             'no-new-func': 'error',
             'no-new-native-nonconstructor': 'error',
             'no-new-wrappers': 'error',

source/caffe.js

@@ -574,7 +574,7 @@ caffe.Attribute = class {
     }
 
     get visible() {
-        return this._visible === false ? false : true;
+        return this._visible !== false;
     }
 };
 

source/circle.js

@@ -429,7 +429,7 @@ circle.Attribute = class {
     }
 
     get visible() {
-        return this._visible === false ? false : true;
+        return this._visible !== false;
     }
 };
 
@@ -438,7 +438,7 @@ circle.Argument = class {
     constructor(name, value, visible) {
         this.name = name;
         this.value = value;
-        this.visible = visible === false ? false : true;
+        this.visible = visible !== false;
     }
 };
 

source/coreml.js

@@ -257,7 +257,7 @@ coreml.Argument = class {
     constructor(name, value, visible) {
         this.name = name;
         this.value = value;
-        this.visible = visible === false ? false : true;
+        this.visible = visible !== false;
     }
 };
 

source/darknet.js

@@ -120,7 +120,7 @@ darknet.Graph = class {
             const type = new darknet.TensorType('float32', make_shape(shape, 'load_weights'));
             const initializer = new darknet.Tensor(type, data);
             const value = new darknet.Value('', null, initializer);
-            return new darknet.Argument(name, visible === false ? false : true, [value]);
+            return new darknet.Argument(name, visible !== false, [value]);
         };
         const load_batch_normalize_weights = (layer, prefix, size) => {
             layer.weights.push(load_weights(`${prefix}scale`, [size], prefix === ''));
@@ -932,7 +932,7 @@ darknet.Attribute = class {
     }
 
     get visible() {
-        return this._visible === false ? false : true;
+        return this._visible !== false;
     }
 };
 

source/keras.js

@@ -1064,7 +1064,7 @@ keras.Node = class {
                         inputIndex++;
                         continue;
                     }
-                    visible = input.visible === false ? false : true;
+                    visible = input.visible !== false;
                     if (this._type.inputs[inputIndex].list) {
                         list = true;
                     }
@@ -1240,7 +1240,7 @@ keras.Attribute = class {
     }
 
     get visible() {
-        return this._visible === false ? false : true;
+        return this._visible !== false;
     }
 
     static _convert(value) {

source/mxnet.js

@@ -743,7 +743,7 @@ mxnet.Attribute = class {
     }
 
     get visible() {
-        return this._visible === false ? false : true;
+        return this._visible !== false;
     }
 };
 

source/ncnn.js

@@ -648,7 +648,7 @@ ncnn.Attribute = class {
     }
 
     get visible() {
-        return this._visible === false ? false : true;
+        return this._visible !== false;
     }
 };
 

source/onednn.js

@@ -276,7 +276,7 @@ onednn.Attribute = class {
     }
 
     get visible() {
-        return this._visible === false ? false : true;
+        return this._visible !== false;
     }
 };
 

source/onnx.js

@@ -245,7 +245,7 @@ onnx.Argument = class {
         this.value = value;
         this.type = type || null;
         this.description = description || null;
-        this.visible = visible === false ? false : true;
+        this.visible = visible !== false;
     }
 };
 

source/tflite.js

@@ -439,7 +439,7 @@ tflite.Attribute = class {
     }
 
     get visible() {
-        return this._visible === false ? false : true;
+        return this._visible !== false;
     }
 };
 
@@ -448,7 +448,7 @@ tflite.Argument = class {
     constructor(name, value, visible) {
         this.name = name;
         this.value = value;
-        this.visible = visible === false ? false : true;
+        this.visible = visible !== false;
     }
 };
 

source/view.js

@@ -3680,7 +3680,7 @@ view.Tensor = class {
             switch (dataType) {
                 case 'boolean':
                     for (; offset < max; offset += stride) {
-                        results.push(view.getUint8(offset) === 0 ? false : true);
+                        results.push(view.getUint8(offset) !== 0);
                     }
                     break;
                 case 'qint8':