Add dot-notation lint rule

publish/eslint.config.js

@@ -31,7 +31,7 @@ export default [
             'default-case': 'error',
             'default-case-last': 'error',
             'default-param-last': 'error',
-            // 'dot-notation': 'error',
+            'dot-notation': 'error',
             'eqeqeq': 'error',
             'for-direction': 'error',
             'func-name-matching': 'error',

source/coreml-proto.js

@@ -4219,7 +4219,7 @@ CoreML.Specification.MILSpec.Block = class Block {
 CoreML.Specification.MILSpec.Argument = class Argument {
 
     constructor() {
-        this["arguments"] = [];
+        this.arguments = [];
     }
 
     static decode(reader, length) {
@@ -4229,7 +4229,7 @@ CoreML.Specification.MILSpec.Argument = class Argument {
             const tag = reader.uint32();
             switch (tag >>> 3) {
                 case 1:
-                    message["arguments"].push(CoreML.Specification.MILSpec.Argument.Binding.decode(reader, reader.uint32()));
+                    message.arguments.push(CoreML.Specification.MILSpec.Argument.Binding.decode(reader, reader.uint32()));
                     break;
                 default:
                     reader.skipType(tag & 7);
@@ -4246,7 +4246,7 @@ CoreML.Specification.MILSpec.Argument = class Argument {
             const tag = reader.tag();
             switch (tag) {
                 case "arguments":
-                    message["arguments"].push(CoreML.Specification.MILSpec.Argument.Binding.decodeText(reader));
+                    message.arguments.push(CoreML.Specification.MILSpec.Argument.Binding.decodeText(reader));
                     break;
                 default:
                     reader.field(tag, message);

source/nnabla-proto.js

@@ -345,7 +345,7 @@ nnabla.Network = class Network {
     constructor() {
         this.repeat_info = [];
         this.variable = [];
-        this["function"] = [];
+        this.function = [];
     }
 
     static decode(reader, length) {
@@ -367,7 +367,7 @@ nnabla.Network = class Network {
                     message.variable.push(nnabla.Variable.decode(reader, reader.uint32()));
                     break;
                 case 200:
-                    message["function"].push(nnabla.Function.decode(reader, reader.uint32()));
+                    message.function.push(nnabla.Function.decode(reader, reader.uint32()));
                     break;
                 default:
                     reader.skipType(tag & 7);
@@ -396,7 +396,7 @@ nnabla.Network = class Network {
                     message.variable.push(nnabla.Variable.decodeText(reader));
                     break;
                 case "function":
-                    message["function"].push(nnabla.Function.decodeText(reader));
+                    message.function.push(nnabla.Function.decodeText(reader));
                     break;
                 default:
                     reader.field(tag, message);

source/paddle-proto.js

@@ -469,7 +469,7 @@ paddle.framework.proto.OpDesc.Attr.prototype.scalar = null;
 paddle.framework.proto.OpDesc.Var = class Var {
 
     constructor() {
-        this["arguments"] = [];
+        this.arguments = [];
     }
 
     static decode(reader, length) {
@@ -482,7 +482,7 @@ paddle.framework.proto.OpDesc.Var = class Var {
                     message.parameter = reader.string();
                     break;
                 case 2:
-                    message["arguments"].push(reader.string());
+                    message.arguments.push(reader.string());
                     break;
                 default:
                     reader.skipType(tag & 7);
@@ -505,7 +505,7 @@ paddle.framework.proto.OpDesc.Var = class Var {
                     message.parameter = reader.string();
                     break;
                 case "arguments":
-                    reader.array(message["arguments"], () => reader.string());
+                    reader.array(message.arguments, () => reader.string());
                     break;
                 default:
                     reader.field(tag, message);

source/python.js

@@ -5957,7 +5957,7 @@ python.Execution = class {
                     throw new python.Error(`Node ${name} has already been deserialized before.`);
                 }
                 this.serialized_name_to_node.set(name, fx_node);
-                fx_node.meta['val'] = this.serialized_name_to_meta.get(name);
+                fx_node.meta.val = this.serialized_name_to_meta.get(name);
             }
             deserialize_sym_op_inputs(inputs) {
                 return inputs.map((input) => this.deserialize_input(input.arg));
@@ -6056,9 +6056,9 @@ python.Execution = class {
             }
             deserialize_metadata(metadata) {
                 const ret = {};
-                const stack_trace = metadata['stack_trace'];
+                const stack_trace = metadata.stack_trace;
                 if (stack_trace) {
-                    ret['stack_trace'] = stack_trace;
+                    ret.stack_trace = stack_trace;
                 }
                 const deserialize_meta_func = (serialized_target) => {
                     let module = null;
@@ -6081,22 +6081,22 @@ python.Execution = class {
                     }
                     return target;
                 };
-                const nn_module_stack_str = metadata['nn_module_stack'];
+                const nn_module_stack_str = metadata.nn_module_stack;
                 if (nn_module_stack_str) {
                     const import_nn_module_stack = (key, path, ty) => {
                         return [key, [path, ty]];
                     };
                     const nn_module_stack = new Map(nn_module_stack_str.split(';').map((item) => import_nn_module_stack(...item.split(','))));
-                    ret['nn_module_stack'] = nn_module_stack;
+                    ret.nn_module_stack = nn_module_stack;
                 }
-                const source_fn_st_str = metadata['source_fn_stack'];
+                const source_fn_st_str = metadata.source_fn_stack;
                 if (source_fn_st_str) {
                     const source_fn_st = [];
                     for (const source_fn_str of source_fn_st_str.split(';')) {
                         const [name, target_str] = source_fn_str.split(',');
                         source_fn_st.push([name, deserialize_meta_func(target_str)]);
                     }
-                    ret['source_fn_stack'] = source_fn_st;
+                    ret.source_fn_stack = source_fn_st;
                 }
                 return ret;
             }

source/tf-proto.js

@@ -850,7 +850,7 @@ tensorflow.GraphDef.prototype.debug_info = null;
 tensorflow.FunctionDefLibrary = class FunctionDefLibrary {
 
     constructor() {
-        this["function"] = [];
+        this.function = [];
         this.gradient = [];
         this.registered_gradients = [];
     }
@@ -862,7 +862,7 @@ tensorflow.FunctionDefLibrary = class FunctionDefLibrary {
             const tag = reader.uint32();
             switch (tag >>> 3) {
                 case 1:
-                    message["function"].push(tensorflow.FunctionDef.decode(reader, reader.uint32()));
+                    message.function.push(tensorflow.FunctionDef.decode(reader, reader.uint32()));
                     break;
                 case 2:
                     message.gradient.push(tensorflow.GradientDef.decode(reader, reader.uint32()));
@@ -885,7 +885,7 @@ tensorflow.FunctionDefLibrary = class FunctionDefLibrary {
             const tag = reader.tag();
             switch (tag) {
                 case "function":
-                    message["function"].push(tensorflow.FunctionDef.decodeText(reader));
+                    message.function.push(tensorflow.FunctionDef.decodeText(reader));
                     break;
                 case "gradient":
                     message.gradient.push(tensorflow.GradientDef.decodeText(reader));
@@ -2837,7 +2837,7 @@ tensorflow.SavedObject = class SavedObject {
                     message.asset = tensorflow.SavedAsset.decode(reader, reader.uint32());
                     break;
                 case 6:
-                    message["function"] = tensorflow.SavedFunction.decode(reader, reader.uint32());
+                    message.function = tensorflow.SavedFunction.decode(reader, reader.uint32());
                     break;
                 case 7:
                     message.variable = tensorflow.SavedVariable.decode(reader, reader.uint32());
@@ -2896,7 +2896,7 @@ tensorflow.SavedObject = class SavedObject {
                     message.asset = tensorflow.SavedAsset.decodeText(reader);
                     break;
                 case "function":
-                    message["function"] = tensorflow.SavedFunction.decodeText(reader);
+                    message.function = tensorflow.SavedFunction.decodeText(reader);
                     break;
                 case "variable":
                     message.variable = tensorflow.SavedVariable.decodeText(reader);

tools/protoc.js

@@ -1416,7 +1416,7 @@ protoc.Generator = class {
     }
 
     static _propertyReference(name) {
-        if (!/^[$\w_]+$/.test(name) || protoc.Generator._isKeyword(name)) {
+        if (!/^[$\w_]+$/.test(name)) {
             return `["${name.replace(/\\/g, '\\\\').replace(/"/g, "\\\"")}"]`;
         }
         return `.${name}`;