2
0
Эх сурвалжийг харах

Revert "Add asserts to more internal errors"

Some uses of these functions are being used in a way that we don't want to assert.

This reverts commit 397ba30a03b5cb2153bae06422f296280ecfc525.
Tom Care 8 жил өмнө
parent
commit
bcc695afbc

+ 0 - 3
lib/Common/Exceptions/Throw.cpp

@@ -69,19 +69,16 @@ namespace Js {
     void Throw::FatalInternalError()
     {
         int scenario = 2;
-        AssertMsg(false, "Fatal internal error");
         ReportFatalException(NULL, E_FAIL, Fatal_Internal_Error, scenario);
     }
 
     void Throw::FatalInternalErrorEx(int scenario)
     {
-        AssertMsg(false, "Fatal internal error");
         ReportFatalException(NULL, E_FAIL, Fatal_Internal_Error, scenario);
     }
 
     void Throw::FatalProjectionError()
     {
-        AssertMsg(false, "Fatal projection error");
         RaiseException((DWORD)DBG_TERMINATE_PROCESS, EXCEPTION_NONCONTINUABLE, 0, NULL);
     }
 

+ 0 - 4
lib/Runtime/Library/JavascriptError.cpp

@@ -263,14 +263,12 @@ namespace Js
     \
     void __declspec(noreturn) JavascriptError::err_method(ScriptContext* scriptContext, int32 hCode, EXCEPINFO* pei) \
     { \
-        if (hCode == VBSERR_InternalError) AssertMsg(false, "Internal error"); \
         JavascriptError *pError = create_method(scriptContext); \
         SetMessageAndThrowError(scriptContext, pError, hCode, pei); \
     } \
     \
     void __declspec(noreturn) JavascriptError::err_method(ScriptContext* scriptContext, int32 hCode, PCWSTR varName) \
     { \
-        if (hCode == VBSERR_InternalError) AssertMsg(false, "Internal error"); \
         JavascriptLibrary *library = scriptContext->GetLibrary(); \
         JavascriptError *pError = library->create_method(); \
         JavascriptError::SetErrorMessage(pError, hCode, varName, scriptContext); \
@@ -279,7 +277,6 @@ namespace Js
     \
     void __declspec(noreturn) JavascriptError::err_method(ScriptContext* scriptContext, int32 hCode, JavascriptString* varName) \
     { \
-        if (hCode == VBSERR_InternalError) AssertMsg(false, "Internal error"); \
         JavascriptLibrary *library = scriptContext->GetLibrary(); \
         JavascriptError *pError = library->create_method(); \
         JavascriptError::SetErrorMessage(pError, hCode, varName->GetSz(), scriptContext); \
@@ -288,7 +285,6 @@ namespace Js
     \
     void __declspec(noreturn) JavascriptError::err_method##Var(ScriptContext* scriptContext, int32 hCode, ...) \
     { \
-        if (hCode == VBSERR_InternalError) AssertMsg(false, "Internal error"); \
         JavascriptLibrary *library = scriptContext->GetLibrary(); \
         JavascriptError *pError = library->create_method(); \
         va_list argList; \